Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43753 )
Change subject: mb/google/zork/var/ezkinil: Configure boot media for new SKUs
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43753/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/ezkinil/variant.c:
https://review.coreboot.org/c/coreboot/+/43753/2/src/mainboard/google/zork/v...
PS2, Line 22: return 1;
Lucas do all the devices have FW_CONFIG provisioned in CBI? If so, we should move to that.
Bhanu is planning on implementing fw_config bindings in coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43753
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b89cc4568283d5dbebf0ab7ac578368d3a3637e
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 2
Gerrit-Owner: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Lucas Chen
lucas.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Teresa Tseng
teresa_tseng@quanta.corp-partner.google.com
Gerrit-CC: Vincent Wang
vwang@chromium.org
Gerrit-Comment-Date: Tue, 28 Jul 2020 18:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment