Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38179 )
Change subject: drivers/pc80/rtc: Clean up some inlined functions ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38179/1/src/drivers/pc80/rtc/mc1468... File src/drivers/pc80/rtc/mc146818rtc.c:
https://review.coreboot.org/c/coreboot/+/38179/1/src/drivers/pc80/rtc/mc1468... PS1, Line 87: cmos
CMOS
Done
https://review.coreboot.org/c/coreboot/+/38179/1/src/drivers/pc80/rtc/mc1468... PS1, Line 417: /* Upon return the caller is guaranteed 244 microseconds to complete any
Please use […]
Done
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... File src/include/pc80/mc146818rtc.h:
https://review.coreboot.org/c/coreboot/+/38179/1/src/include/pc80/mc146818rt... PS1, Line 138: if (control_state & RTC_SET)
wasn't obvious on the first sight
I have redone this.