Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42650 )
Change subject: sb/intel/i82801gx: Move `acpi_fill_fadt` to fadt.c ......................................................................
Patch Set 2:
(12 comments)
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/fadt.c:
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 35: 1
I am just cutting and pasting the code. I will not change anything in this commit to ease review. […]
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 44: 1
ACPI_ADDRESS_SPACE_IO
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 51: 0
ACPI_ADDRESS_SPACE_MEMORY
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 54: 0
ACPI_ACCESS_SIZE_UNDEFINED
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 58: 1
ACPI_ADDRESS_SPACE_IO
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 65: 0
ACPI_ADDRESS_SPACE_MEMORY […]
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 68: 0
ACPI_ACCESS_SIZE_UNDEFINED
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 72: 1
ACPI_ADDRESS_SPACE_IO
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 79: 1
ACPI_ADDRESS_SPACE_IO
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 86: 1
ACPI_ADDRESS_SPACE_IO
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 93: 0
ACPI_ADDRESS_SPACE_MEMORY
CB:42652
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280... PS1, Line 96: 0
ACPI_ACCESS_SIZE_UNDEFINED
CB:42652