17 Oct
2021
17 Oct
'21
10:45 a.m.
Attention is currently required from: Shelley Chen, Nico Huber, Furquan Shaikh, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58331 )
Change subject: [RFC] pci_mmio_cfg: Move guard around pci_s_* functions to x86 ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2: Should we error out if `pci_mmio_cfg.h` is included when `CONFIG_MMCONF_SUPPORT=n`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaeed6ab43ad61b7c0e14572b12bf4ec06b6a26af
Gerrit-Change-Number: 58331
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 17 Oct 2021 10:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment