Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Matt DeVillier, Zheng Bao, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69429 )
Change subject: amdfwtool: Set the base address of AMDFW as relative ......................................................................
Patch Set 3:
(7 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163249): https://review.coreboot.org/c/coreboot/+/69429/comment/3245b697_90d468aa PS3, Line 2294: case 0: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163249): https://review.coreboot.org/c/coreboot/+/69429/comment/b3e168fe_84c9de4f PS3, Line 2295: case 0xFA0000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163249): https://review.coreboot.org/c/coreboot/+/69429/comment/a6bdf53a_9775d4dc PS3, Line 2296: case 0xF20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163249): https://review.coreboot.org/c/coreboot/+/69429/comment/a44a78a0_dcd2f887 PS3, Line 2297: case 0xE20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163249): https://review.coreboot.org/c/coreboot/+/69429/comment/d7173775_7e15ff3b PS3, Line 2298: case 0xC20000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163249): https://review.coreboot.org/c/coreboot/+/69429/comment/66560bac_b740c203 PS3, Line 2299: case 0x820000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163249): https://review.coreboot.org/c/coreboot/+/69429/comment/044e6746_c48d7b34 PS3, Line 2300: case 0x020000: /* Fall through */ Prefer 'fallthrough;' over fallthrough comment