build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36333 )
Change subject: src/southbridge: change "unsigned" to "unsigned int" ......................................................................
Patch Set 3:
(10 comments)
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/broadcom/bc... File src/southbridge/broadcom/bcm5785/smbus.h:
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/broadcom/bc... PS3, Line 108: static int do_smbus_send_byte(unsigned int smbus_io_base, unsigned int device, unsigned char val) line over 96 characters
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/broadcom/bc... PS3, Line 135: static int do_smbus_read_byte(unsigned int smbus_io_base, unsigned int device, unsigned int address) line over 96 characters
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/broadcom/bc... PS3, Line 165: static int do_smbus_write_byte(unsigned int smbus_io_base, unsigned int device, unsigned int address, unsigned char val) line over 96 characters
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/ck80... File src/southbridge/nvidia/ck804/early_setup_car.c:
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/ck80... PS3, Line 27: static int set_ht_link_buffer_counts_chain(uint8_t ht_c_num, unsigned int vendorid, unsigned int val) { return 0; /* stub */}; line over 96 characters
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/ck80... File src/southbridge/nvidia/ck804/early_smbus.h:
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/ck80... PS3, Line 14: int ck804_smbus_read_byte(unsigned int, unsigned int, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/ck80... PS3, Line 14: int ck804_smbus_read_byte(unsigned int, unsigned int, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/ck80... PS3, Line 14: int ck804_smbus_read_byte(unsigned int, unsigned int, unsigned int); function definition argument 'unsigned int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/mcp5... File src/southbridge/nvidia/mcp55/smbus.h:
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/mcp5... PS3, Line 83: static int do_smbus_send_byte(unsigned int smbus_io_base, unsigned int device, unsigned char val) line over 96 characters
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/mcp5... PS3, Line 113: static int do_smbus_read_byte(unsigned int smbus_io_base, unsigned int device, unsigned int address) line over 96 characters
https://review.coreboot.org/c/coreboot/+/36333/3/src/southbridge/nvidia/mcp5... PS3, Line 145: static int do_smbus_write_byte(unsigned int smbus_io_base, unsigned int device, unsigned int address, unsigned char val) line over 96 characters