Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33193 )
Change subject: soc/intel/{cml, whl}: Add option to skip HECI function disable in SMM ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/33193/1/src/soc/intel/cannonlake/Kconfig@30 PS1, Line 30: CHROMEOS
Correct. If a board does not want to disable Heci, they can set Heci1Enabled to 1.
I will make the change.
BTW does this mean that ICL/CNL do not support disabling of HECI using FSP?
As i understand SMM mode will work for all future SOC is that WHL and CML had older CPU hence SMM mode was not giving other access. Do you prefer to use FSP for HECI disable or SMM mode without FSP?
https://review.coreboot.org/#/c/33193/5/src/soc/intel/common/block/smm/Kconf... File src/soc/intel/common/block/smm/Kconfig:
https://review.coreboot.org/#/c/33193/5/src/soc/intel/common/block/smm/Kconf... PS5, Line 27: SKIP_HECI_FUNCTION_DISABLE_USING_SMM
Does this have to be a negative option? i.e. […]
I can change that as well.