Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38142 )
Change subject: soc/intel/broadwell: Drop old forked version of SMBUS support
......................................................................
Patch Set 2:
I'd add a note to the commit message that we're switching to using the sb/common implementation, since it's not immediately obvious, and as stated implies that we're simply dropping an unused component, not replacing it.
same for identical change on soc/common
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbd54b5671ea2a94aea5db4642698ef679540625
Gerrit-Change-Number: 38142
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Fri, 03 Jan 2020 20:22:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment