Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31498 )
Change subject: sb/intel/bd82x6x: Fix default IRQ mapping
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31498/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31498/1//COMMIT_MSG@11
PS1, Line 11: some register bits).
Can we mention the functions that additionally have their interrupt pin routed after this change?
Is there any risk that we could trigger interrupt on hardware that will not have their OS driver loaded? I don't remember what would happen then, that GSI/PIRQ line may end up being disabled completely.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31498
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33f82702ea9c1b9c22ce14f01ee630dbf6203362
Gerrit-Change-Number: 31498
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Tue, 19 Feb 2019 19:19:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment