Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32740 )
Change subject: lib.h: Add convenient memcpy() variants
......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
Wondering if this is something that would get general
approval and adoption?
I tried to find a way to check if somebody passes
a pointer by accident, but that doesn't seem easy
to do.
https://review.coreboot.org/#/c/32740/1/src/include/lib.h
File src/include/lib.h:
https://review.coreboot.org/#/c/32740/1/src/include/lib.h@74
PS1, Line 74: #define memcpy_dlen(dst, src) memcpy(dst, src, sizeof(dst))
Isn't this expecting pointers for src and dst? If not, shouldn't these be &dst and &src?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b23066b3bcc29ff679e620f723ce1da5057aa03
Gerrit-Change-Number: 32740
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 May 2019 14:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment