Hello build bot (Jenkins), Furquan Shaikh, Julius Werner, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46855
to look at the new patch set (#2).
Change subject: mrc_cache: Move force memory retraining code into mrc_cache ......................................................................
mrc_cache: Move force memory retraining code into mrc_cache
Currently forced memory retraining is handled in fsp 2.0. Moving the code into mrc_cache so more platforms can utilize it. Since it is unclear what is supposed to occur when there RECOVERY_MRC_CACHE present in the fmap, added a config MRC_ALWAYS_RETRAIN_IN_RECOVERY for users to explicity specify that if there is no RECOVERY_MRC_CACHE, then they will always perform memory training when booting into recovery mode. The default behavior when this config is not selected is that recovery boot and normal boot will share the same MRC_CACHE.
BOG=b:150502246 BRANCH=None TEST=1. run dut-control power_state:rec_force_mrc twice on lazor ensure that memory training happens both times run dut-control power_state:rec twice on lazor ensure that memory training happens only first time 2. remove HAS_RECOVERY_MRC_CACHE from lazor Kconfig boot twice to ensure memory training has occurred dut-control power_state:rec and make sure memory training doesn't occur. 3. Add MRC_ALWAYS_RETRAIN_IN_RECOVERY to lazor Kconfig boot twice to ensure memory training has occurred dut-control power_state:rec and make sure memory training occurs. dut-control power_state:rec a few more times to make sure memory training always occurs on a recovery boot.
Change-Id: I3875a7b4a4ba3c1aa8a3c1507b3993036a7155fc Signed-off-by: Shelley Chen shchen@google.com --- M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/mrc_cache/Kconfig M src/drivers/mrc_cache/mrc_cache.c 3 files changed, 23 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/46855/2