Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31253 )
Change subject: RFC: riscv: Add initial support for 32bit boards ......................................................................
Patch Set 2:
(2 comments)
@Jonathan: How do you want to handle spike?
Has only been tested in qemu. Should definitely be tested on unleashed to make sure multi-hart support still works.
https://review.coreboot.org/#/c/31253/2/src/mainboard/emulation/qemu-riscv/K... File src/mainboard/emulation/qemu-riscv/Kconfig:
https://review.coreboot.org/#/c/31253/2/src/mainboard/emulation/qemu-riscv/K... PS2, Line 20: if BOARD_EMULATION_QEMU_RISCV_RV64 Is this setup fine?
https://review.coreboot.org/#/c/31253/2/src/mainboard/emulation/qemu-riscv/K... File src/mainboard/emulation/qemu-riscv/Kconfig.name:
https://review.coreboot.org/#/c/31253/2/src/mainboard/emulation/qemu-riscv/K... PS2, Line 2: bool "QEMU RISC-V rv64" are we happy with those names?