19 Feb
2020
19 Feb
'20
7:54 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37306 )
Change subject: trogdor: mainboard reference all QUPv3 FW drivers ......................................................................
Patch Set 20: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37306/20/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37306/20/src/mainboard/google/trogd... PS20, Line 42: qup_load_se_firmware(QUPV3_1_SE4, SE_PROTOCOL_SPI); /* Fingerprint SPI */ nit: Would be nice to order these by QUP number.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ff5dd63fac28ffa558aec71e79a6de87d7885e0
Gerrit-Change-Number: 37306
Gerrit-PatchSet: 20
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 20 Feb 2020 03:54:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment