Attention is currently required from: Subrata Banik.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/cmn/block/cse: Implement an API to get ISHC version ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74209/comment/ecc8b06c_39ede67f PS2, Line 7: soc/intel/cmn
soc/intel/cmd/block/cse
Ack
https://review.coreboot.org/c/coreboot/+/74209/comment/5868eb15_0761511d PS2, Line 13: ISHC version is verified on the Nissa board using a debug patch
Able to build and boot google/nivviks. […]
Ack
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74209/comment/c92ffe3e_ff2aecde PS2, Line 1215:
Add a comment saying, this cmd can only work post FSP-M (after CSE DID cmd being sent)
Ack
https://review.coreboot.org/c/coreboot/+/74209/comment/af52b5a2_9202e23a PS2, Line 1215: : bool get_ishc_version(struct fw_version *resp_version)
Ack