[coreboot-gerrit] Change in coreboot[master]: pciexp: Add support for allocating PCI express hotplug resources

[Jeremy Soller (Code Review)]

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )

Change subject: pciexp: Add support for allocating PCI express hotplug resources
......................................................................

Patch Set 4:

(2 comments)

I would also like to know what is absolutely required for merging this patch. We at System76 have been using a similar patch successfully on production systems with Thunderbolt 3 for a few months.

It would help to reiterate what is left that must be fixed before this can get a +2.

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c 
File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c@126... 
PS2, Line 1269: 		link->subordinate = link->secondary + dev->hotplug_buses;
> It is too early to adjust link->subordinate here. […]

I have not seen this issue. Adjusting it later on causes the value to not take effect.

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c 
File src/device/pciexp_device.c:

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@... 
PS2, Line 527: 	pciexp_scan_bridge(dev);
> It should be possible to adjust dev->link_list->subordinate here to either max N or additional N PCI […]

When I attempted to do this earlier, it did not take effect.