5 Oct
2020
5 Oct
'20
12:43 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45930 )
Change subject: [NEED RETEST] soc/intel/common/block/systemagent/memmap.c: Align cached region ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45930/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/memmap.c:
https://review.coreboot.org/c/coreboot/+/45930/2/src/soc/intel/common/block/... PS2, Line 70: postcar_frame_add_mtrr(pcf, top_of_ram - 8 * MiB, 16 * MiB, MTRR_TYPE_WRBACK);
Hrm, good point. Aligning upwards would work better for this.
Done but needs to be re-tested.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic64fd6d3d9e8ab4c78d68b910a476f9c4eb2d353
Gerrit-Change-Number: 45930
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Oct 2020 12:43:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment