Attention is currently required from: Francois Toguo Fotso, Furquan Shaikh, Tim Wawrzynczak, Kane Chen, Karthik Ramasubramanian.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57685 )
Change subject: soc/intel/common: Add CPU Crashlog PCI driver
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Patchset:
PS6:
Looks good, just a nit and a question.
File src/soc/intel/common/block/crashlog/cpu_crashlog.c:
https://review.coreboot.org/c/coreboot/+/57685/comment/bb9aded3_3a73dac3
PS6, Line 5: #include "crashlog_lib.h"
nit - group of local includes follows group of system includes
https://review.coreboot.org/c/coreboot/+/57685/comment/8e2cf5c3_20ed4387
PS6, Line 263: if (!is_dev_enabled(dev))
Would .init ever get called on a disabled device?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cb61fa2570adcfe51680141ee12e0e83930bb19
Gerrit-Change-Number: 57685
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 19:47:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment