17 Dec
2020
17 Dec
'20
1:11 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48497 )
Change subject: mb/google/volteer: Add GPIO to drobit support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48497/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/drobit/gpio.c:
https://review.coreboot.org/c/coreboot/+/48497/4/src/mainboard/google/voltee... PS4, Line 144: /* assert reset on reboot */ code indent should use tabs where possible
--
To view, visit https://review.coreboot.org/c/coreboot/+/48497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54ba182c6da3db282961b3c72a4d2d11d1001e95
Gerrit-Change-Number: 48497
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Zhuohao Lee zhuohao@chromium.org
Gerrit-Comment-Date: Thu, 17 Dec 2020 09:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment