Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44187 )
Change subject: soc/intel/common/cse_lite: Perform a board specific reset
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44187/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44187/1//COMMIT_MSG@9
PS1, Line 9: ME
this is functionality that is specific to CSE Lite
Done
https://review.coreboot.org/c/coreboot/+/44187/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/44187/1/src/soc/intel/common/block/...
PS1, Line 360: /* Default weak implementation, does nothing. */
Should this weak function contain the `do_global_reset()`, since that would become the default imple […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8663e7f25461e58e45766e2ac00d752bfa191d8b
Gerrit-Change-Number: 44187
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Aug 2020 05:10:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment