[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add Acoustic features

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )

Change subject: soc/intel/tigerlake: Add Acoustic features
......................................................................

Patch Set 10:

(4 comments)

https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/chi... 
File src/soc/intel/tigerlake/chip.h:

https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/chi... 
PS3, Line 157: IA,GT,SA,VLCC and FIVR
> ok.Will Fix.

Done

https://review.coreboot.org/c/coreboot/+/45052/3/src/soc/intel/tigerlake/chi... 
PS3, Line 168:  0 - Fast/2
             : 	 * 1 - Fast/4
             : 	 * 2 - Fast/8
             : 	 * 3 - Fast/16
             : 	 */
> OK. Will use enums.

Done

https://review.coreboot.org/c/coreboot/+/45052/8/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/45052/8/src/soc/intel/tigerlake/fsp... 
PS8, Line 260: 	for (i = 0; i < ARRAY_SIZE(config->SlowSlewRate); i++)
> Why not do this as a single memcpy using ARRAY_SIZE * sizeof array element?

Done

https://review.coreboot.org/c/coreboot/+/45052/8/src/soc/intel/tigerlake/fsp... 
PS8, Line 264: 	for (i = 0; i < ARRAY_SIZE(config->FastPkgCRampDisable); i++)
> Why not do this as a single memcpy using ARRAY_SIZE * sizeof array element?

Done