16 Sep
2020
16 Sep
'20
9:24 a.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45316 )
Change subject: src: Remove redundant <device/pnp_def.h> ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45316/1/src/include/device/pnp.h File src/include/device/pnp.h:
https://review.coreboot.org/c/coreboot/+/45316/1/src/include/device/pnp.h@a6 PS1, Line 6: #include <device/pnp_def.h>
I like the idea to include indirectly <device/pnp_def.h> using <device/pnp. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/45316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9903ae456c32db4ba346020659c17c27a939e89
Gerrit-Change-Number: 45316
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Sep 2020 16:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment