[coreboot-gerrit] Change in coreboot[master]: xeon_sp/cpx: Enable PCH thermal device via FSP

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44075 )

Change subject: xeon_sp/cpx: Enable PCH thermal device via FSP
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/44075/4/src/soc/intel/xeon_sp/cpx/r... 
File src/soc/intel/xeon_sp/cpx/romstage.c:

https://review.coreboot.org/c/coreboot/+/44075/4/src/soc/intel/xeon_sp/cpx/r... 
PS4, Line 67: 2: Enabled in ACPI mode
> In this case, we cannot set this value

Oh, hm. If we're not going to use it, it doesn't matter. If we need to be able to support ACPI mode, we would need to have something like `pch_thermal_dev_acpi_mode` in devicetree, and some more logic to handle it.

Or, just override the FSP-M UPD in `mainboard_memory_init_params`.