build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36661 )
Change subject: [RFC]cpu/x86/smm: Add a unified way of handling save_states ......................................................................
Patch Set 1:
(16 comments)
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... File src/cpu/x86/smm/smm_save_state.c:
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 62: return &state->eax; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 81: return NULL;; Statements terminations use 1 semicolon
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 87: return &state->rax; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 93: return &state->rdx; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 95: return &state->io_misc_info; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 114: return &state->rax; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 120: return &state->rdx; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 122: return &state->io_misc_info; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 141: return &state->rax; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 147: return &state->rdx; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 149: return &state->smm_io_trap_offset; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 189: return ss_get_helper(cpu, IO_MISC_INFO, misc_info, sizeof(*misc_info), em64t100_get_reg_ptr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 204: return ss_get_helper(cpu, IO_MISC_INFO, misc_info, sizeof(*misc_info), em64t101_get_reg_ptr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 219: return ss_get_helper(cpu, SMM_IO_TRAP_OFFSET, io_trap, sizeof(*io_trap), amd64_get_reg_ptr); line over 96 characters
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 265: break; break is not useful after a goto or return
https://review.coreboot.org/c/coreboot/+/36661/1/src/cpu/x86/smm/smm_save_st... PS1, Line 269: break; break is not useful after a goto or return