16 comments:
File src/cpu/x86/smm/smm_save_state.c:
Patch Set #1, Line 62: return &state->eax;
code indent should use tabs where possible
Patch Set #1, Line 81: return NULL;;
Statements terminations use 1 semicolon
Patch Set #1, Line 87: return &state->rax;
code indent should use tabs where possible
Patch Set #1, Line 93: return &state->rdx;
code indent should use tabs where possible
Patch Set #1, Line 95: return &state->io_misc_info;
code indent should use tabs where possible
Patch Set #1, Line 114: return &state->rax;
code indent should use tabs where possible
Patch Set #1, Line 120: return &state->rdx;
code indent should use tabs where possible
Patch Set #1, Line 122: return &state->io_misc_info;
code indent should use tabs where possible
Patch Set #1, Line 141: return &state->rax;
code indent should use tabs where possible
Patch Set #1, Line 147: return &state->rdx;
code indent should use tabs where possible
Patch Set #1, Line 149: return &state->smm_io_trap_offset;
code indent should use tabs where possible
Patch Set #1, Line 189: return ss_get_helper(cpu, IO_MISC_INFO, misc_info, sizeof(*misc_info), em64t100_get_reg_ptr);
line over 96 characters
Patch Set #1, Line 204: return ss_get_helper(cpu, IO_MISC_INFO, misc_info, sizeof(*misc_info), em64t101_get_reg_ptr);
line over 96 characters
Patch Set #1, Line 219: return ss_get_helper(cpu, SMM_IO_TRAP_OFFSET, io_trap, sizeof(*io_trap), amd64_get_reg_ptr);
line over 96 characters
Patch Set #1, Line 265: break;
break is not useful after a goto or return
Patch Set #1, Line 269: break;
break is not useful after a goto or return
To view, visit change 36661. To unsubscribe, or for help writing mail filters, visit settings.