Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31536 )
Change subject: soc/intel/cannonlake: Set correct serirq mode based on SERIRQ_CONTINUOUS_MODE
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Thanks for the update. In the long run, I'd prefer to
use the common `enum serirq_mode`, though.
https://review.coreboot.org/#/c/31536/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31536/4//COMMIT_MSG@7
PS4, Line 7: soc/intel/cannonlake: Set correct serirq mode based on SERIRQ_CONTINUOUS_MODE
This line is too long and needs an update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31536
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ad4f5a6c7391fc6e813ec1306c708f449a69f59
Gerrit-Change-Number: 31536
Gerrit-PatchSet: 4
Gerrit-Owner: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Feb 2019 20:54:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment