Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33093 )
Change subject: soc/intel/{skl,cnl,icl}: Drop soc_uart_set_legacy_mode() ......................................................................
Patch Set 2:
Patch Set 2:
What about some mainboard still use legacy UART, like port 0x3f8? Not every Intel mainboard select LPSS_UART_FOR_CONSOLE right? Like galileo?
Sorry for the confusion. This is not about common code. I've adapted the commit message, hoping that makes it clearer.
Currently that's okay for all the platform we have supported in coreboot, but what about some new board porting will require the legacy UART port to be wokring? Drop it here will loose the possibility.