Patch Set 2:

What about some mainboard still use legacy UART, like port 0x3f8? Not every Intel mainboard select LPSS_UART_FOR_CONSOLE right? Like galileo?

Sorry for the confusion. This is not about common
code. I've adapted the commit message, hoping that
makes it clearer.

Currently that's okay for all the platform we have supported in coreboot, but what about some new board porting will require the legacy UART port to be wokring? Drop it here will loose the possibility.

View Change

To view, visit change 33093. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96e304bdee4eadb52725027d0d662ef75f3d4307
Gerrit-Change-Number: 33093
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 29 May 2019 22:20:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment