Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43356 )
Change subject: arch/x86/exception: Add support for printing stack to x86_64
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43356/1/src/arch/x86/exception.c
File src/arch/x86/exception.c:
https://review.coreboot.org/c/coreboot/+/43356/1/src/arch/x86/exception.c@55...
PS1, Line 550: u64 *ptr = (u64 *)(ALIGN_DOWN(info->rsp, sizeof(u64)) + MDUMP_SIZE - sizeof(u64));
Can we use uintptr_t unconditionally? And perhaps we could rename the register fields to use the 64-bit names?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43356
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0571dd3a02acc4b70bdd00221e69cc2e20afec3
Gerrit-Change-Number: 43356
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 13 Jul 2020 15:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment