Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37283 )
Change subject: soc/intel/common/block/cse: Modify handling of HMRFPO_ENABLE command ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37283/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37283/5//COMMIT_MSG@21 PS5, Line 21: opmode Temp Disable Mode.
I still have not seen any documentation from Intel about this. It […]
The patch is to update the prerequisites for sending HMRFPO command. In the current FWs, the prerequisite is that the CSME working mode and and operation mode should be 'normal'. However when the MRP mode is enabled HMRFPO enable will be allowed when CSME operation mode is "soft temporary disable". The MRP is a new option supported in CML, documentation update is WIP. Meanwhile we have explained it in the commit message.
I agree on versioning part and my suggestion is to link it with the MRP rather than the CSME version. 1. Check CSME working state and operation mode is "Normal" 2. If yes, then send HMRFPO command 3. If no, then check if MRP is enabled and operation mode is "soft temp disabled" 3.1 if yes send HMRFPO command. If not, don't send the command.