Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou.
Eric Lai has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85015?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/rull: Add Elan touchscreen
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/rull/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85015/comment/2908caea_63bbdde1?usp... :
PS3, Line 232: 280
please check this value can be shorten or not.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85015?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7f6dce0175c2940abfa14c4e407414912063112
Gerrit-Change-Number: 85015
Gerrit-PatchSet: 3
Gerrit-Owner: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 07 Nov 2024 04:51:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No