Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35736 )
Change subject: [WIP] soc/intel: Refactor device ACPI names
......................................................................
Patch Set 3:
Patch Set 1:
I think we would want to push these strings to devicetree.cb.
Devicetree does not seem appropriate as this is an SOC level binding and not something the mainboard should tweak. These names need to match what is in any static ASL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35736
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f2ee991efbd0911dfce5fdf5c5d92de9b7cc652
Gerrit-Change-Number: 35736
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 20:04:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment