Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39036 )
Change subject: mainboard/google/dedede: Migrate onto SKU ID helpers ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... PS12, Line 8: select EC_GOOGLE_CHROMEEC_SKUID Nit: Move it after EC_GOOGLE_CHROMEEC_ESPI. Just organized in alphabetical order.
https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... File src/mainboard/google/dedede/board_info.c:
https://review.coreboot.org/c/coreboot/+/39036/12/src/mainboard/google/deded... PS12, Line 52: sku_id == SKU_UNKNOWN ||
nit: sku_id > SKU_MAX is a superset of sku_id == SKU_UNKNOWN, so we could just write sku_id > SKU_MA […]
It is removed altogether here - https://review.coreboot.org/c/coreboot/+/39039/11 and is a follow-up CL in this CL stack.