HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41312 )
Change subject: mb/intel/kblrvp: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/intel/kblrvp: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I2f60e9bc3c8c176480e80d8e1920341b320b51af Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/romstage.c 3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/41312/1
diff --git a/src/mainboard/intel/kblrvp/bootblock.c b/src/mainboard/intel/kblrvp/bootblock.c index 19c5e9e..2fbf694 100644 --- a/src/mainboard/intel/kblrvp/bootblock.c +++ b/src/mainboard/intel/kblrvp/bootblock.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h>
static void early_config_gpio(void) diff --git a/src/mainboard/intel/kblrvp/chromeos.c b/src/mainboard/intel/kblrvp/chromeos.c index 270c84d..013a828 100644 --- a/src/mainboard/intel/kblrvp/chromeos.c +++ b/src/mainboard/intel/kblrvp/chromeos.c @@ -3,7 +3,6 @@ #include <boot/coreboot_tables.h> #include <device/device.h> #include <gpio.h> -#include <soc/gpio.h> #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c index 281a24f..395d880 100644 --- a/src/mainboard/intel/kblrvp/romstage.c +++ b/src/mainboard/intel/kblrvp/romstage.c @@ -6,7 +6,6 @@ #include <gpio.h> #include "gpio.h" #include <soc/romstage.h> -#include <soc/gpio.h> #include "spd/spd.h" #include <spd_bin.h> #include "board_id.h"