Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35990 )
Change subject: cpu/intel/car: Correctly cache the bootblock with C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 3: Code-Review+1
Would really like to see the #cpp stuff in `mtrr.h`
even if we can clean it up soon anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8104ca9c51e4d2eccdb277e4c2111d2da662f3e
Gerrit-Change-Number: 35990
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Oct 2019 20:53:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment