Attention is currently required from: Nico Huber, Patrick Rudolph, Angel Pons, Subrata Banik, Michael Niewöhner.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48658 )
Change subject: soc/intel/*: Add TPM decode range to soc_get_fixed_mmio_ranges()
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/alderlake/espi.c:
https://review.coreboot.org/c/coreboot/+/48658/comment/86177e7a_1c4f0ebe
PS2, Line 30: 0x8000
Knowing that TGL uses 64 KiB, maybe ADL uses 64 KiB as well. […]
ADL shows 64 KiB here in the #627270 bios core/uncore spec, but #626817 PCH EDS vol 1 shows 32 KiB here... Subrata, could you help confirm the correct value?
File src/soc/intel/tigerlake/espi.c:
https://review.coreboot.org/c/coreboot/+/48658/comment/7db62047_5be02485
PS2, Line 33: 0x8000
Done
Ok, another mismatch like ADL, BIOS core/uncore spec (#611569) shows 64 KiB but PCH EDS vol. 1 (#576591) shows 32 KiB. Subrata, could you help here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f2257b55a712b936763cfd289c2c4b1633e8049
Gerrit-Change-Number: 48658
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 14 Jan 2021 15:44:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment