Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't en MAX98357A in dt ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@7 PS3, Line 7: en enable
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@9 PS3, Line 9: doesn't have this packed does not have these speaker amps, so don't ...
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@14 PS3, Line 14: base base -> baseboard (?)
https://review.coreboot.org/c/coreboot/+/37822/3//COMMIT_MSG@14 PS3, Line 14: wont won't
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... PS3, Line 6: DRIVERS_I2C_DA7219 What about this one? AFAICT, this is only enabled in kohaku's dt.
Perhaps it is cleaner to move both of these to the non-baseboards that need them.
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... PS3, Line 147: device pci 1f.3 on perhaps it would be cleaner to move this out of the baseboard and into the other variants?