Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45448 )
Change subject: nb/intel/gm45: Add more DMIBAR/EPBAR registers ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
+2 for the register names I checked
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/pcie.c:
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... PS3, Line 42: ; Beside that it's ugly, I already see this commit:
nb/intel/gm45: Drop useless semicolons
There are no statements on these lines.
What you can do, either
* add a comment before the semicolon, explaining the gap, e.g.
/* idle loop */;
* use braces
while (...) { }
* or even add a keyword
do { } while (...);