Attention is currently required from: Mike Banon, Kyösti Mälkki, Alexander Couzens, Patrick Rudolph, Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61919 )
Change subject: mb/lenovo/g505s/irq_tables.c: Use ALIGN_UP macro
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/lenovo/g505s/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/61919/comment/09f2461a_7a670205
PS1, Line 80: if (sum != pirq->checksum)
: pirq->checksum = sum;
the assignment can be done unconditionally and the check be dropped. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bd5e09f51918fe4c7e954edf54ab4d9bc629fd1
Gerrit-Change-Number: 61919
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 07 Mar 2022 15:18:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment