Hello Aaron Durbin, Todd Broch, Sumeet R Pawnikar, build bot (Jenkins), Martin Roth, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31655
to review the following change.
Change subject: Revert "mb/google/poppy/variants/atlas: Update DPTF parameters" ......................................................................
Revert "mb/google/poppy/variants/atlas: Update DPTF parameters"
This reverts commit 5e90ef8c356099e42612bc97976c67092d0810ff.
Reason for revert: The 1s internal causes early throttle in usage spike. (log in b/123895423#comment3)
BUG=b:113101335 BRANCH=None TEST=learning from Nocturne
Change-Id: Id6467b51eb937b89b4c08641f36266544c8fa176 --- M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/31655/1
diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl index 85eb891..685f4dd 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/dptf.asl @@ -50,7 +50,7 @@
Name (DTRT, Package () { /* CPU Throttle Effect on CPU */ - Package () { _SB.PCI0.B0D4, _SB.PCI0.B0D4, 100, 10, 0, 0, 0, 0 }, + Package () { _SB.PCI0.B0D4, _SB.PCI0.B0D4, 100, 50, 0, 0, 0, 0 },
/* CPU Throttle Effect on TSR0 */ Package () { _SB.PCI0.B0D4, _SB.DPTF.TSR0, 100, 600, 0, 0, 0, 0 },