Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46669 )
Change subject: soc/amd/common/acpi: Create platform.asl to define acpi transitions ......................................................................
Patch Set 2:
(2 comments)
You'll need to rebase this patch set on the current ToT. The patch that it's currently based on isn't building correctly.
https://review.coreboot.org/c/coreboot/+/46669/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46669/2//COMMIT_MSG@16 PS2, Line 16: Signed-Off-By
Jenkins is complaining: "No Signed-off-by line in commit message" […]
Git will do this for you - you don't need to do it by hand. git commit -s
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... File src/soc/amd/common/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... PS2, Line 8: Scope(_SB){ Why does _INI need to go in this scope? We define the method at the root level, so it doesn't seem like it needs a different scope.