Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard
......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40581/36//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40581/36//COMMIT_MSG@25
PS36, Line 25: The ACPI code has been taken from System76 CML-U mainboard series.
probably they won't work 100% on the stock ec; I will check that with L14xCU but I'm pretty sure we can do acpi platform-specific (cml, kbl, ...) or even more generic, since they are veeeeeery similiar
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f83fab64e4cc9036698ca0fdd5edbb677d77eb9
Gerrit-Change-Number: 40581
Gerrit-PatchSet: 36
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Tue, 11 Aug 2020 12:16:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment