Attention is currently required from: Tarun Tuli, Kapil Porwal, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74805 )
Change subject: soc/intel: Make CSE sync in romstage default disable
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/74805/comment/5057344a_c94cd43e
PS2, Line 115: if SOC_INTEL_CSE_LITE_SKU
When CSE Lite should happen is board choice, i don't this should part of SoC Kconfig list.
moving into chromeos specific board, there would be too much effort doing such.
Please feel free to pick this if you think there are better ways to do so.
take a look into https://review.coreboot.org/c/coreboot/+/74805/2/src/soc/intel/cannonlake/Kc... there is no such hard rule that SOC_INTEL_CSE_LITE_SKU check can't exist inside SoC code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74805
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f5017fbcf917201eaf8233089050bd31c3d1917
Gerrit-Change-Number: 74805
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 17:08:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment