Attention is currently required from: Tim Wawrzynczak. Star Labs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55128 )
Change subject: src/mainboard: Add Star Labs labtop series ......................................................................
Patch Set 7:
(6 comments)
File Documentation/distributions.md:
https://review.coreboot.org/c/coreboot/+/55128/comment/74d0022b_61639ddf PS6, Line 11: ### Purism : : [Purism](https://www.puri.sm) sells laptops with a focus on user privacy and : security; part of that effort is to minimize the amount of proprietary and/or : binary code. Their laptops ship with a blob-free OS and coreboot firmware : with a neutralized Intel Management Engine (ME) and SeaBIOS as the payload.
Does this belong with this commit?
I was bundling all the documentation into one, seemed to miss the relevant 'Documentation/mainboard/starlabs/labtop.md' on the last patchset though.
File src/mainboard/starlabs/labtop/Kconfig:
https://review.coreboot.org/c/coreboot/+/55128/comment/45900b91_ee41222b PS6, Line 26: # select HAVE_IFD_BIN : # select HAVE_ME_BIN
Why commented out?
ME and Descriptor aren't in the blobs repository, which causes the build to fail. It's a bit of a grey area so still waiting on confirmation that we can upload these.
https://review.coreboot.org/c/coreboot/+/55128/comment/2d27e13e_49c05239 PS6, Line 89: : config IFD_BIN_PATH : string : default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/$(CONFIG_VARIANT_DIR)/flashregion_0_flashdescriptor.bin"
you have HAVE_IFD_BIN commented out, so this doesn't apply
Ack
https://review.coreboot.org/c/coreboot/+/55128/comment/10a44a29_d43f7752 PS6, Line 94: config ME_BIN_PATH : string : default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/$(CONFIG_VARIANT_DIR)/flashregion_2_intel_me.bin"
You have HAVE_ME_BIN commented out, so this doesn't apply
Ack
https://review.coreboot.org/c/coreboot/+/55128/comment/577a5fc4_ac8761cd PS6, Line 112: #config VGA_BIOS_FILE : # string : # default "pci8086,9b41.rom" if BOARD_STARLABS_LABTOP_CML : # default "pci8086,5917.rom" if BOARD_STARLABS_LABTOP_KBL
leave this out instead of commented out?
Done
File src/mainboard/starlabs/labtop/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/55128/comment/234ab532_61093d2c PS6, Line 54:
space
Done