Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45091 )
Change subject: drivers/intel/mipi_camera: Remove unused condition
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I'm not sure what to make of the "unused" claim. Here's a counter-example:
https://review.coreboot.org/c/coreboot/+/31168/1/src/mainboard/google/poppy/...
I'm not clear on whether the scheme for NVM has changed.
"Unused" may not be the correct word. From what I understand looking at the driver code (drivers/misc/eeprom/at24.c), the schemes may be used interchangeably. i.e., HID with INT3499 or a HID with PRP0001 and compatibility with "atmel,24c08"
Correct, the kernel can bind through ACPI with a native _HID, or use PRP0001 and then require a "compatible" string for OF matching.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45091
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad7afa7b3170982eb5d6215e766f3e98f7a89213
Gerrit-Change-Number: 45091
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Sep 2020 21:51:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment