Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support ......................................................................
Patch Set 3:
(3 comments)
If you wouldn't mind adding those comments, the rest LGTM
https://review.coreboot.org/c/coreboot/+/35023/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/3/payloads/libpayload/drivers... PS3, Line 267: SUPER_SPEED A comment to indicate that the fallthrough from one case to the other would be very helpful. /* Intentional fallthrough */ or something like that?
https://review.coreboot.org/c/coreboot/+/35023/3/payloads/libpayload/drivers... PS3, Line 287: case SUPER_SPEED: A comment to indicate that the fallthrough from one case to the other would be very helpful. /* Intentional fallthrough */ or something like that?
https://review.coreboot.org/c/coreboot/+/35023/3/payloads/libpayload/drivers... PS3, Line 323: SUPER_SPEED A comment to indicate that the fallthrough from one case to the other would be very helpful. /* Intentional fallthrough */ or something like that?