Attention is currently required from: Harsha B R, Himanshu Sahdev, Julius Werner, Yu-Ping Wu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75521?usp=email )
Change subject: vboot: Drop argument to select slot from `vb2ex_ec_protect()`
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75521/comment/5727f6f2_12fe9b3a :
PS4, Line 9: has
have
Acknowledged
https://review.coreboot.org/c/coreboot/+/75521/comment/dd429af8_e65ab2d3 :
PS4, Line 11: is
~~is~~
Acknowledged
https://review.coreboot.org/c/coreboot/+/75521/comment/a6bd8737_46030ae6 :
PS4, Line 11: currently takes
: about 17 ms to lock down the EC.
better to mention time savings with vboot changes instead/alongwith
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75521?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2974f0cb43ba800c2aaeac4876ebaa052b5ee793
Gerrit-Change-Number: 75521
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Harsha B R
harsha.b.r@intel.com
Gerrit-Attention: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 05 Jun 2023 10:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-MessageType: comment