Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47990 )
Change subject: soc/intel/common/fast_spi: Add extended decode window support
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47990/8/src/soc/intel/common/block/...
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47990/8/src/soc/intel/common/block/...
PS8, Line 269: fast_spi_get_ext_bios_window(&ext_bios_base, &ext_bios_size);
:
: /* Enable extended BIOS only if size of Bios region is greater than 16MiB */
: if (ext_bios_size == 0 || ext_bios_base == 0)
: return;
Actually, we will have to unconditionally configure the window here using the base provided by the S […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idafd8be0261892122d0b5a95d9ce9d5604a10cf2
Gerrit-Change-Number: 47990
Gerrit-PatchSet: 9
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Dec 2020 21:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment