Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35745 )
Change subject: soc/skylake/fsp: enable PCIe Advanced Error Reporting (AER) by default
......................................................................
Patch Set 1:
(1 comment)
Please list the affected boards in the commit message. Would
make it easier to find reviewers.
https://review.coreboot.org/c/coreboot/+/35745/1/src/soc/intel/skylake/chip_...
File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35745/1/src/soc/intel/skylake/chip_...
PS1, Line 300: CONFIG_MAX_ROOT_PORTS
nit, how about ARRAY_SIZE() or sizeof()? I hate it to see when some external
struct is written with a made up (supposed to match) size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I172329d8d42c3be02e64300675d646edfbee8b72
Gerrit-Change-Number: 35745
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 06 Oct 2019 16:59:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment