Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48348 )
Change subject: azalia: Make `find_verb` function non-static
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48348/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48348/5//COMMIT_MSG@9
PS5, Line 9: Rename it to `azalia_find_verb` as the function is now globally visible.
Why?
because the summary and the message advertise two different changes, which is pretty confusion when only reading git log. The first part should be a summary of the second, detailed part
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie66323b2c62139e86d3d7e003f6653a3def7b5f2
Gerrit-Change-Number: 48348
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Dec 2020 20:06:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment