Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38700 )
Change subject: drivers/intel/fsp2_0: Add weak reservation for FSP-M memory ......................................................................
Patch Set 4: -Code-Review
(2 comments)
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38700/4//COMMIT_MSG@14 PS4, Line 14: memory consumed by FSP-M.
What will it do with the information? What makes it platform specific?
Looks here for a better explanation: https://review.coreboot.org/c/coreboot/+/38702/4
https://review.coreboot.org/c/coreboot/+/38700/4/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/api.h:
https://review.coreboot.org/c/coreboot/+/38700/4/src/drivers/intel/fsp2_0/in... PS4, Line 56: fsp_reserve_fspm_mem Maybe we should rename this to fsp_fspm_loaded_callback(). We are using it as a notification to the chip code. I think the current name it too specific.